Conversation
exowanderer
left a comment
exowanderer
left a comment
There was a problem hiding this comment.
I made a lot of comments and suggestions. I promise that they are 95% "PEP8 this" and "format suggestion that".
I will make a new branch with a PR that implements all of my suggestions so that neither of you has to go through them one by one.
The comment list here will be my check list after both of you approve the PR from my integrations_pep8 into the integration branch.
|
I submited a PR(#24) from the This PR addresses 95% of my comments and suggestions. They are largely related to PEP8 formatting, my suggest formatting, and creating a logger.py file instead of using print statements If you review and agree with the PR, as well as merge it, then we can close this review comments. |
…py inputs; tests timed out
…i.py included; logger in api.py functional
…ed them in llm_config.py
…moved rag_piipeline from api.py; introduced rag_pipeline from rag.py into api.py
To prevent huge redownloads on llm change.
2 participants
TODO